Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/single precision for remaining physics #3

Merged
merged 4 commits into from
Jun 7, 2022
Merged

feature/single precision for remaining physics #3

merged 4 commits into from
Jun 7, 2022

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented May 22, 2022 •
edited
Loading

WORK IN PROGRESS

  • Change working precision in physics/flake.F90
  • Interface changes in physics/aer_cloud.F, physics/rrtmgp_lw_cloud_sampling.F90, physics/rrtmgp_sw_cloud_sampling.F90
    • Keep random number generator in double precision, I believe this is important
  • Waiting on feature/single precision earth-system-radiation/rte-rrtmgp#171
    • Note: this has been fixed otherwise by Robert Pincus and feature/single precision earth-system-radiation/rte-rrtmgp#171 was closed.
    • The CPP directive in Robert's solution is different from the one use by ccpp-physics and passed to rte-rrtmgp, i.e. a translations needs to happen somewhere.
    • This translation is not included in this PR.

@climbfuji climbfuji mentioned this pull request May 22, 2022
Closed
@SamuelTrahanNOAA SamuelTrahanNOAA merged commit 510b51c into SamuelTrahanNOAA:sing_prec_from_main Jun 7, 2022
@climbfuji climbfuji deleted the feature/single_precision branch June 7, 2022 20:19
SamuelTrahanNOAA pushed a commit that referenced this pull request Oct 11, 2022
@AnningCheng-NOAA
Merge pull request #3 from climbfuji/mraerosol_dom
95c67d3 
Update to mraerosol branch from Dom
SamuelTrahanNOAA pushed a commit that referenced this pull request Jun 15, 2023
@joeolson42
Merge pull request #3 from grantfirl/mynn_snowfix_gjf
da02a14 
Cray compiler fix
SamuelTrahanNOAA pushed a commit that referenced this pull request Jul 5, 2023
@MicroTed
Merge pull request #3 from grantfirl/ufs-dev-tm_gjf
aa433c3 
Revert combination, update to ufs/dev, and update CODEOWNERS
SamuelTrahanNOAA pushed a commit that referenced this pull request Dec 12, 2023
@lisa-bengtsson
Merge pull request #3 from SamuelTrahanNOAA/C3_updates_updates
4bca28b 
Merge PR NCAR#121 and resolve conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelTrahanNOAA SamuelTrahanNOAA Awaiting requested review from SamuelTrahanNOAA SamuelTrahanNOAA will be requested when the pull request is marked ready for review SamuelTrahanNOAA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @SamuelTrahanNOAA